Move V2 azure-identity to azure-core#48949
Draft
srnagar wants to merge 3 commits intoAzure:mainfrom
Draft
Conversation
github-actions
Bot
added
the
Azure.Core.V2
Comment on lines
+11
to
+13
| requires msal4j.persistence.extension; | ||
| requires com.sun.jna; | ||
| requires com.sun.jna.platform; |
Member
There was a problem hiding this comment.
Should determine the credentials needing this and split them out into a separate package as we don't want these dependencies in Core.
| [azure_ca]: https://learn.microsoft.com/azure/security/fundamentals/azure-ca-details?tabs=root-and-subordinate-cas-list#client-compatibility-for-public-pkis | ||
| [azure_cli]: https://learn.microsoft.com/cli/azure | ||
| [azure_identity]: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/identity/azure-identity | ||
| [azure_identity]: https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/core-v2/azure-core |
Member
There was a problem hiding this comment.
We'll need to think about how we link to Identity stuff now that it's in Core.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily migrates the
azure-identityv2 credential classes into theazure-corev2 package, consolidating identity-related functionality undercom.azure.v2.core.identity. It also removes the separateidentity-v2module, updates dependencies, and adjusts references throughout the codebase to reflect the new package structure. Additionally, several new dependencies and build configurations are introduced to support the refactored code.Key changes:
Identity Package Consolidation and Refactoring
com.azure.v2.identitytocom.azure.v2.core.identity, including credential builders and implementations, and updated all imports and references accordingly. This includes renaming and moving files such asAuthorizationCodeCredential,AzureCliCredential,AzureDeveloperCliCredential, and their respective builders. [1] [2] [3] [4] [5] [6] [7]sdk/identity-v2module from the main project structure (pom.xml), effectively consolidating all v2 identity functionality underazure-core.Dependency and Build Configuration Updates
azure-coreformsal4j,msal4j-persistence-extension, and testing libraries such asmockito-inlineandbyte-buddy. Also introduced themaven-enforcer-pluginto ban specific dependency versions as needed. [1] [2]appconfiguration-v2and versioning files to remove direct dependencies onazure-identityv2 and to use the newcore.identitypackage for credentials in both source and test code. [1] [2] [3] [4] [5]Checkstyle and Linting Adjustments
azure-core's checkstyle configuration for identity-related implementation classes, reflecting the new package structure and to accommodate specific code patterns.These changes collectively streamline the identity experience in the v2 SDK by centralizing identity management, improving maintainability, and preparing for future enhancements.